[all-commits] [llvm/llvm-project] 0e9a4a: [mlir] Move the Buffer related source files out of...

River Riddle via All-commits all-commits at lists.llvm.org
Mon Jan 24 19:30:27 PST 2022 

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0e9a4a3b65363c082087864b9ff5e0da33be90da
      https://github.com/llvm/llvm-project/commit/0e9a4a3b65363c082087864b9ff5e0da33be90da
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-01-24 (Mon, 24 Jan 2022)

  Changed paths:
    A mlir/include/mlir/Dialect/Bufferization/Transforms/BufferUtils.h
    M mlir/include/mlir/Dialect/Bufferization/Transforms/Passes.h
    M mlir/include/mlir/Dialect/Bufferization/Transforms/Passes.td
    M mlir/include/mlir/Dialect/StandardOps/Transforms/Passes.h
    R mlir/include/mlir/Transforms/BufferUtils.h
    M mlir/include/mlir/Transforms/Passes.h
    M mlir/include/mlir/Transforms/Passes.td
    M mlir/lib/Dialect/Bufferization/Transforms/BufferDeallocation.cpp
    A mlir/lib/Dialect/Bufferization/Transforms/BufferOptimizations.cpp
    A mlir/lib/Dialect/Bufferization/Transforms/BufferResultsToOutParams.cpp
    A mlir/lib/Dialect/Bufferization/Transforms/BufferUtils.cpp
    M mlir/lib/Dialect/Bufferization/Transforms/CMakeLists.txt
    M mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ArithInterfaceImpl.cpp
    M mlir/lib/Dialect/StandardOps/Transforms/TensorConstantBufferize.cpp
    R mlir/lib/Transforms/BufferOptimizations.cpp
    R mlir/lib/Transforms/BufferResultsToOutParams.cpp
    R mlir/lib/Transforms/BufferUtils.cpp
    M mlir/lib/Transforms/CMakeLists.txt
    M mlir/lib/Transforms/PassDetail.h

  Log Message:
  -----------
  [mlir] Move the Buffer related source files out of Transforms/

Transforms/ should only contain dialect-independent transformations,
and these files are a much better fit for the bufferization dialect anyways.

Differential Revision: https://reviews.llvm.org/D117839


  Commit: 2e2c0738e80e9c2b7c1413ca4719d5be2df4c6b5
      https://github.com/llvm/llvm-project/commit/2e2c0738e80e9c2b7c1413ca4719d5be2df4c6b5
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-01-24 (Mon, 24 Jan 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/MemRef/Transforms/Passes.h
    M mlir/include/mlir/Dialect/MemRef/Transforms/Passes.td
    M mlir/include/mlir/Transforms/Passes.h
    M mlir/include/mlir/Transforms/Passes.td
    M mlir/lib/Dialect/MemRef/Transforms/CMakeLists.txt
    A mlir/lib/Dialect/MemRef/Transforms/NormalizeMemRefs.cpp
    A mlir/lib/Dialect/MemRef/Transforms/PassDetail.h
    M mlir/lib/Dialect/MemRef/Transforms/ResolveShapedTypeResultDims.cpp
    M mlir/lib/Transforms/CMakeLists.txt
    R mlir/lib/Transforms/NormalizeMemRefs.cpp

  Log Message:
  -----------
  [mlir:Transforms] Move NormalizeMemRefs to MemRef/Transforms/

Transforms/  should only contain transformations that are dialect-independent and
this pass interacts with MemRef operations (making it a better fit for living in that
dialect).

Differential Revision: https://reviews.llvm.org/D117841


  Commit: a70aa7bb0d9a6066831b339e0a09a2c1bc74fe2b
      https://github.com/llvm/llvm-project/commit/a70aa7bb0d9a6066831b339e0a09a2c1bc74fe2b
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-01-24 (Mon, 24 Jan 2022)

  Changed paths:
    A mlir/include/mlir/Dialect/Affine/LoopFusionUtils.h
    A mlir/include/mlir/Dialect/Affine/LoopUtils.h
    M mlir/include/mlir/Dialect/Affine/Passes.h
    M mlir/include/mlir/Dialect/Affine/Passes.td
    M mlir/include/mlir/Dialect/Affine/Utils.h
    M mlir/include/mlir/Dialect/SCF/Passes.h
    M mlir/include/mlir/Dialect/SCF/Passes.td
    M mlir/include/mlir/Dialect/SCF/Utils.h
    M mlir/include/mlir/Interfaces/LoopLikeInterface.h
    A mlir/include/mlir/Transforms/ControlFlowSinkUtils.h
    R mlir/include/mlir/Transforms/LoopFusionUtils.h
    R mlir/include/mlir/Transforms/LoopUtils.h
    M mlir/include/mlir/Transforms/Passes.h
    M mlir/include/mlir/Transforms/Passes.td
    R mlir/include/mlir/Transforms/Utils.h
    M mlir/lib/Conversion/SCFToGPU/SCFToGPU.cpp
    M mlir/lib/Conversion/SCFToStandard/SCFToStandard.cpp
    M mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
    M mlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp
    M mlir/lib/Dialect/Affine/Transforms/AffineDataCopyGeneration.cpp
    M mlir/lib/Dialect/Affine/Transforms/AffineLoopInvariantCodeMotion.cpp
    M mlir/lib/Dialect/Affine/Transforms/AffineParallelize.cpp
    M mlir/lib/Dialect/Affine/Transforms/CMakeLists.txt
    A mlir/lib/Dialect/Affine/Transforms/LoopCoalescing.cpp
    A mlir/lib/Dialect/Affine/Transforms/LoopFusion.cpp
    M mlir/lib/Dialect/Affine/Transforms/LoopTiling.cpp
    M mlir/lib/Dialect/Affine/Transforms/LoopUnroll.cpp
    M mlir/lib/Dialect/Affine/Transforms/LoopUnrollAndJam.cpp
    M mlir/lib/Dialect/Affine/Transforms/PassDetail.h
    A mlir/lib/Dialect/Affine/Transforms/PipelineDataTransfer.cpp
    M mlir/lib/Dialect/Affine/Transforms/SimplifyAffineStructures.cpp
    M mlir/lib/Dialect/Affine/Utils/CMakeLists.txt
    A mlir/lib/Dialect/Affine/Utils/LoopFusionUtils.cpp
    A mlir/lib/Dialect/Affine/Utils/LoopUtils.cpp
    M mlir/lib/Dialect/Affine/Utils/Utils.cpp
    M mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp
    M mlir/lib/Dialect/Linalg/Transforms/CodegenStrategy.cpp
    M mlir/lib/Dialect/Linalg/Transforms/HoistPadding.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Hoisting.cpp
    M mlir/lib/Dialect/Linalg/Transforms/LinalgStrategyPasses.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
    M mlir/lib/Dialect/Linalg/Utils/Utils.cpp
    M mlir/lib/Dialect/MemRef/Transforms/NormalizeMemRefs.cpp
    M mlir/lib/Dialect/SCF/Transforms/CMakeLists.txt
    A mlir/lib/Dialect/SCF/Transforms/ParallelLoopCollapsing.cpp
    M mlir/lib/Dialect/SCF/Transforms/Utils.cpp
    M mlir/lib/Dialect/Vector/VectorTransferSplitRewritePatterns.cpp
    M mlir/lib/Dialect/Vector/VectorTransforms.cpp
    M mlir/lib/Dialect/Vector/VectorUnrollDistribute.cpp
    M mlir/lib/Interfaces/LoopLikeInterface.cpp
    M mlir/lib/Transforms/CMakeLists.txt
    M mlir/lib/Transforms/CSE.cpp
    M mlir/lib/Transforms/ControlFlowSink.cpp
    R mlir/lib/Transforms/LoopCoalescing.cpp
    R mlir/lib/Transforms/LoopFusion.cpp
    M mlir/lib/Transforms/LoopInvariantCodeMotion.cpp
    R mlir/lib/Transforms/ParallelLoopCollapsing.cpp
    M mlir/lib/Transforms/PassDetail.h
    R mlir/lib/Transforms/PipelineDataTransfer.cpp
    M mlir/lib/Transforms/Utils/CMakeLists.txt
    M mlir/lib/Transforms/Utils/ControlFlowSinkUtils.cpp
    M mlir/lib/Transforms/Utils/DialectConversion.cpp
    R mlir/lib/Transforms/Utils/LoopFusionUtils.cpp
    R mlir/lib/Transforms/Utils/LoopUtils.cpp
    R mlir/lib/Transforms/Utils/Utils.cpp
    M mlir/test/lib/Dialect/Affine/CMakeLists.txt
    M mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp
    M mlir/test/lib/Dialect/Affine/TestAffineLoopParametricTiling.cpp
    A mlir/test/lib/Dialect/Affine/TestLoopFusion.cpp
    A mlir/test/lib/Dialect/Affine/TestLoopMapping.cpp
    M mlir/test/lib/Dialect/Affine/TestLoopPermutation.cpp
    M mlir/test/lib/Dialect/Affine/TestVectorizationUtils.cpp
    M mlir/test/lib/Dialect/SCF/CMakeLists.txt
    A mlir/test/lib/Dialect/SCF/TestLoopParametricTiling.cpp
    A mlir/test/lib/Dialect/SCF/TestLoopUnrolling.cpp
    M mlir/test/lib/Transforms/CMakeLists.txt
    M mlir/test/lib/Transforms/TestConstantFold.cpp
    R mlir/test/lib/Transforms/TestLoopFusion.cpp
    R mlir/test/lib/Transforms/TestLoopMapping.cpp
    R mlir/test/lib/Transforms/TestLoopParametricTiling.cpp
    R mlir/test/lib/Transforms/TestLoopUnrolling.cpp
    M mlir/unittests/Transforms/CMakeLists.txt

  Log Message:
  -----------
  [mlir:Transforms] Move out the remaining non-dialect independent transforms and utilities

This has been a major TODO for a very long time, and is necessary for establishing a proper
dialect-free dependency layering for the Transforms library. Code was moved to effectively
two main locations:

* Affine/
There was quite a bit of affine dialect related code in Transforms/ do to historical reasons
(of a time way into MLIR's past). The following headers were moved to:
Transforms/LoopFusionUtils.h -> Dialect/Affine/LoopFusionUtils.h
Transforms/LoopUtils.h -> Dialect/Affine/LoopUtils.h
Transforms/Utils.h -> Dialect/Affine/Utils.h

The following transforms were also moved:
AffineLoopFusion, AffinePipelineDataTransfer, LoopCoalescing

* SCF/
Only one SCF pass was in Transforms/ (likely accidentally placed here): ParallelLoopCollapsing
The SCF specific utilities in LoopUtils have been moved to SCF/Utils.h

* Misc:
mlir::moveLoopInvariantCode was also moved to LoopLikeInterface.h given
that it is a simple utility defined in terms of LoopLikeOpInterface.

Differential Revision: https://reviews.llvm.org/D117848


  Commit: 88c1df64bdd379b4fb5a7946124c7f52a9c795da
      https://github.com/llvm/llvm-project/commit/88c1df64bdd379b4fb5a7946124c7f52a9c795da
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-01-24 (Mon, 24 Jan 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/ArmSVE/ArmSVE.td
    M mlir/lib/Dialect/ArmSVE/IR/ArmSVEDialect.cpp
    M mlir/lib/Dialect/ArmSVE/IR/CMakeLists.txt
    M mlir/lib/Dialect/ArmSVE/Transforms/LegalizeForLLVMExport.cpp

  Log Message:
  -----------
  [mlir:ArmSVE][NFC] Remove dead code and unnecessary dependencies

Differential Revision: https://reviews.llvm.org/D117981


  Commit: 65e7cd13bbc6c16804614235aaeaed2e2ed94358
      https://github.com/llvm/llvm-project/commit/65e7cd13bbc6c16804614235aaeaed2e2ed94358
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-01-24 (Mon, 24 Jan 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/GPU/GPUOps.td
    M mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
    M mlir/lib/Dialect/GPU/Transforms/AsyncRegionRewriter.cpp
    M mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp
    M mlir/lib/Dialect/OpenACC/CMakeLists.txt
    M mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
    M mlir/lib/Dialect/Quant/CMakeLists.txt
    M mlir/lib/Dialect/Quant/Transforms/ConvertConst.cpp
    M mlir/lib/Dialect/SCF/CMakeLists.txt
    M mlir/lib/Dialect/SCF/SCF.cpp
    M mlir/lib/Dialect/Shape/IR/CMakeLists.txt
    M mlir/lib/Dialect/Shape/IR/Shape.cpp
    M mlir/lib/Dialect/Shape/IR/ShapeCanonicalization.td
    M mlir/lib/Dialect/SparseTensor/IR/CMakeLists.txt
    M mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

  Log Message:
  -----------
  [mlir] Remove a bunch of unnecessary dialect dependencies

A lot of dialects have dependencies that are unnecessary, either because of copy/paste
of files when creating things or some other means. This commit cleans up a bunch of
the simple ones:

* Copy/Paste or missed during refactoring
Most of the dependencies cleaned up here look like copy/paste errors when creating
new dialects/transformations, or because the dependency wasn't removed during a
refactoring (e.g. when splitting the standard dialect).

* Unnecessary hard coding of constant operations in matchers
There are a few instances where a dialect had a dependency because it
was hardcoding checks for constant operations instead of using the better m_Constant
approach.

Differential Revision: https://reviews.llvm.org/D118062


Compare: https://github.com/llvm/llvm-project/compare/e01e4c9115ad...65e7cd13bbc6

More information about the All-commits mailing list