[all-commits] [llvm/llvm-project] 2b8b48: [libc++][format] Disable default formatter.

mordante via All-commits all-commits at lists.llvm.org
Mon Jan 24 09:14:57 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2b8b48c5a0c40d33569c74924f72cc31055a7b56
      https://github.com/llvm/llvm-project/commit/2b8b48c5a0c40d33569c74924f72cc31055a7b56
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2022-01-24 (Mon, 24 Jan 2022)

  Changed paths:
    M libcxx/include/__format/formatter.h
    M libcxx/include/__format/formatter_bool.h
    M libcxx/include/__format/formatter_integer.h
    M libcxx/include/__format/formatter_string.h
    A libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/types.compile.pass.cpp

  Log Message:
  -----------
  [libc++][format] Disable default formatter.

[format.formatter.spec]/5 lists the requirements for the default
formatter. The original implementation didn't implement this. This
implements the default formatter according to the Standard.

This adds additional test to validate the default formatter is disabled
and the required standard formatters are enabled.

While adding the tests it seems the formatters needed a constraint for the
character types they were valid for.

Implements parts of:
- P0645 Text Formatting

Depends on D115988

Reviewed By: ldionne, #libc

Differential Revision: https://reviews.llvm.org/D115989




More information about the All-commits mailing list