[all-commits] [llvm/llvm-project] ab1add: [clang] Move the definition of ASTDiff (NFC)

kazutakahirata via All-commits all-commits at lists.llvm.org
Sun Jan 23 13:28:35 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ab1add6adc444371268ddbcb169a509559abd9dc
      https://github.com/llvm/llvm-project/commit/ab1add6adc444371268ddbcb169a509559abd9dc
  Author: Kazu Hirata <kazu at google.com>
  Date:   2022-01-23 (Sun, 23 Jan 2022)

  Changed paths:
    M clang/include/clang/Tooling/ASTDiff/ASTDiff.h

  Log Message:
  -----------
  [clang] Move the definition of ASTDiff (NFC)

This patch moves the definition of ASTDiff later within the header
file.

Without this patch, the header depends on the forward decalrations of
SyntaxTree and ComparisonOptions from another header file, which is
not desirable.  Since SyntaxTree and ComparisonOptions are defined in
ASTDiff.h, we can move the definition of ASTDiff later and stop
relying on the forward declarations from another header file.


  Commit: ee591a64a795995fad96d8c16484baa7cacce99f
      https://github.com/llvm/llvm-project/commit/ee591a64a795995fad96d8c16484baa7cacce99f
  Author: Kazu Hirata <kazu at google.com>
  Date:   2022-01-23 (Sun, 23 Jan 2022)

  Changed paths:
    M clang-tools-extra/clangd/DumpAST.h

  Log Message:
  -----------
  [clang] Forward-declare DynTypedNode (NFC)

This patch adds a forward declaraiton of DynTypedNode.

DumpAST.h is relying on the forward declaration of DynTypedNode in
ASTContext.h, which is undesirable.


  Commit: e59964b67e026cde7a1438a8e91ca077a90810e0
      https://github.com/llvm/llvm-project/commit/e59964b67e026cde7a1438a8e91ca077a90810e0
  Author: Kazu Hirata <kazu at google.com>
  Date:   2022-01-23 (Sun, 23 Jan 2022)

  Changed paths:
    M clang/include/clang/AST/ASTContext.h
    M clang/include/clang/Tooling/ASTDiff/ASTDiffInternal.h

  Log Message:
  -----------
  [clang] Remove unused forward declarations (NFC)


Compare: https://github.com/llvm/llvm-project/compare/32dc14f876c4...e59964b67e02


More information about the All-commits mailing list