[all-commits] [llvm/llvm-project] c93491: [lldb] CxxModuleHandler - use cast<> instead of dy...

[Simon Pilgrim via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c93491352cf3146559de7755283f0dd259392126
      https://github.com/llvm/llvm-project/commit/c93491352cf3146559de7755283f0dd259392126
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-01-23 (Sun, 23 Jan 2022)

  Changed paths:
    M lldb/source/Plugins/ExpressionParser/Clang/CxxModuleHandler.cpp

  Log Message:
  -----------
  [lldb] CxxModuleHandler - use cast<> instead of dyn_cast<> to avoid dereference of nullptr

The pointer is dereferenced immediately, so assert the cast is correct instead of returning nullptr


  Commit: d7aa402b4b8a325a68c20d0300ac6bc664766be0
      https://github.com/llvm/llvm-project/commit/d7aa402b4b8a325a68c20d0300ac6bc664766be0
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-01-23 (Sun, 23 Jan 2022)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp

  Log Message:
  -----------
  [lldb] PdbAstBuilder - use cast<> instead of dyn_cast<> to avoid dereference of nullptr

The pointers are dereferenced immediately, so assert the cast is correct instead of returning nullptr


  Commit: d13847bbe5e632ec8f62abc81f74b9351a56d28c
      https://github.com/llvm/llvm-project/commit/d13847bbe5e632ec8f62abc81f74b9351a56d28c
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-01-23 (Sun, 23 Jan 2022)

  Changed paths:
    M lldb/source/Host/common/Terminal.cpp

  Log Message:
  -----------
  [lldb] TerminalState::Save - fix unused variable warning

Non-POSIX target builds don't use the file descriptor


  Commit: 49d38b1d618c02964af93068ee8e1ac753722104
      https://github.com/llvm/llvm-project/commit/49d38b1d618c02964af93068ee8e1ac753722104
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-01-23 (Sun, 23 Jan 2022)

  Changed paths:
    M lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp

  Log Message:
  -----------
  Fix "not all control paths return a value" warning. NFC.


Compare: https://github.com/llvm/llvm-project/compare/df0fd1c301d6...49d38b1d618c