[all-commits] [llvm/llvm-project] 622354: [llvm][ADT] Implement `BitVector::{pop_, }back`

Jan Svoboda via All-commits all-commits at lists.llvm.org
Fri Jan 21 05:51:07 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 622354a522073b0a048a88c957b161fb376a40eb
      https://github.com/llvm/llvm-project/commit/622354a522073b0a048a88c957b161fb376a40eb
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2022-01-21 (Fri, 21 Jan 2022)

  Changed paths:
    M clang-tools-extra/clang-tidy/readability/FunctionSizeCheck.cpp
    M clang-tools-extra/clangd/SourceCode.cpp
    M clang/lib/Format/UnwrappedLineParser.cpp
    M clang/lib/Format/UnwrappedLineParser.h
    M llvm/include/llvm/ADT/BitVector.h
    M llvm/include/llvm/ADT/SmallBitVector.h
    M llvm/lib/MC/MCParser/MasmParser.cpp
    M llvm/unittests/ADT/BitVectorTest.cpp

  Log Message:
  -----------
  [llvm][ADT] Implement `BitVector::{pop_,}back`

LLVM Programmer’s Manual strongly discourages the use of `std::vector<bool>` and suggests `llvm::BitVector` as a possible replacement.

Currently, some users of `std::vector<bool>` cannot switch to `llvm::BitVector` because it doesn't implement the `pop_back()` and `back()` functions.

To enable easy transition of `std::vector<bool>` users, this patch implements `llvm::BitVector::pop_back()` and `llvm::BitVector::back()`.

Reviewed By: dexonsmith

Differential Revision: https://reviews.llvm.org/D117115




More information about the All-commits mailing list