[all-commits] [llvm/llvm-project] 8105e4: [demangler][NFC] Small cleanups and sync

[Nathan Sidwell via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8105e404f186c6f31e08185b37f81e6da904f6d7
      https://github.com/llvm/llvm-project/commit/8105e404f186c6f31e08185b37f81e6da904f6d7
  Author: Nathan Sidwell <nathan at acm.org>
  Date:   2022-01-20 (Thu, 20 Jan 2022)

  Changed paths:
    M libcxxabi/src/demangle/ItaniumDemangle.h
    M llvm/include/llvm/Demangle/ItaniumDemangle.h
    M llvm/include/llvm/Demangle/StringView.h
    M llvm/include/llvm/Demangle/Utility.h

  Log Message:
  -----------
  [demangler][NFC] Small cleanups and sync

Some precursor work to adding module demangling.

* some mismatched comment and code in the demangler

* a const fn was not marked thusly

* we use std::islower.  A direct range check is smaller code (no function call),
  and we know we're in ASCII-land and later in that same function make the same
  assumption about upper-case contiguity.  Heck, maybe just drop the switch's
  precondition and rely on the optimizer to do its thing?

* the directory is cloned in two places, which had gotten out of sync.

Differential Revision: https://reviews.llvm.org/D117800