[all-commits] [llvm/llvm-project] df31ff: [cmake] Make include(GNUInstallDirs) always below ...

John Ericson via All-commits all-commits at lists.llvm.org
Thu Jan 20 10:59:29 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: df31ff1b29bc4c2308ec5df8a7ff0ec2ab0942d4
      https://github.com/llvm/llvm-project/commit/df31ff1b29bc4c2308ec5df8a7ff0ec2ab0942d4
  Author: John Ericson <John.Ericson at Obsidian.Systems>
  Date:   2022-01-20 (Thu, 20 Jan 2022)

  Changed paths:
    M flang/CMakeLists.txt
    M libcxx/CMakeLists.txt
    M libcxxabi/CMakeLists.txt
    M libunwind/CMakeLists.txt
    M lld/CMakeLists.txt
    M lldb/CMakeLists.txt
    M lldb/cmake/modules/LLDBStandalone.cmake
    M lldb/tools/debugserver/CMakeLists.txt
    M llvm/CMakeLists.txt
    M mlir/CMakeLists.txt
    M polly/CMakeLists.txt
    M pstl/CMakeLists.txt

  Log Message:
  -----------
  [cmake] Make include(GNUInstallDirs) always below project(..)

Its defaulting logic must go after `project(..)` to work correctly,  but `project(..)` is often in a standalone condition making this
awkward, since the rest of the condition code may also need GNUInstallDirs.

The good thing is there are the various standalone booleans, which I had missed before. This makes splitting the conditional blocks less awkward.

Reviewed By: arichardson, phosek, beanz, ldionne, #libunwind, #libc, #libc_abi

Differential Revision: https://reviews.llvm.org/D117639




More information about the All-commits mailing list