[all-commits] [llvm/llvm-project] 585abe: [lldb] Rename MemoryTagManager RemoveNonAddressBit...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 585abe3ba506e410b382f8130f72b9368573a781
      https://github.com/llvm/llvm-project/commit/585abe3ba506e410b382f8130f72b9368573a781
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2022-01-20 (Thu, 20 Jan 2022)

  Changed paths:
    M lldb/include/lldb/Target/MemoryTagManager.h
    M lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
    M lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp
    M lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.h
    M lldb/unittests/Process/Utility/MemoryTagManagerAArch64MTETest.cpp

  Log Message:
  -----------
  [lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits

This better describes the intent of the method. Which for AArch64
is removing the top byte which includes the memory tags.

It does not include pointer signatures, for those we need to use
the ABI plugin. The rename makes this a little more clear.

It's a bit awkward that the memory tag manager is removing the whole
top byte not just the memory tags but it's an improvement for now.

Reviewed By: omjavaid

Differential Revision: https://reviews.llvm.org/D117671