[all-commits] [llvm/llvm-project] b4a755: [OpenMP][FIX] Replace ICVs only with values valid ...

Johannes Doerfert via All-commits all-commits at lists.llvm.org
Wed Jan 19 16:41:02 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b4a7559844d06928234d576335316bf82d792c08
      https://github.com/llvm/llvm-project/commit/b4a7559844d06928234d576335316bf82d792c08
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2022-01-19 (Wed, 19 Jan 2022)

  Changed paths:
    M llvm/lib/Transforms/IPO/OpenMPOpt.cpp
    A llvm/test/Transforms/OpenMP/icv_tracking_out_of_scope.ll

  Log Message:
  -----------
  [OpenMP][FIX] Replace ICVs only with values valid at the getter position

While we might know the value if an ICV at a getter position it is not
always clear that we can simply use it. Verify the value is valid first
to avoid invalid IR.

Fixes #53300.


  Commit: dd75a6b2ae5c9c6628fb855473dc2f31073440d0
      https://github.com/llvm/llvm-project/commit/dd75a6b2ae5c9c6628fb855473dc2f31073440d0
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2022-01-19 (Wed, 19 Jan 2022)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    A llvm/test/DebugInfo/NVPTX/crash-missing-DISubprogram.ll

  Log Message:
  -----------
  [DWARF][FIX] Try not to crash for nvptx with missing debug information

This prevents crashes in the OpenMP offload pipeline as not everything
is properly annotated with debug information, e.g., the runtimes we link
in. While we might want to have them annotated, it seems to be generally
useful to gracefully handle missing debug info rather than crashing.

TODO: A test is missing and can hopefully be distilled prior to landing.

This fixes #51079.

Differential Revision: https://reviews.llvm.org/D116959


Compare: https://github.com/llvm/llvm-project/compare/ef95d45138ec...dd75a6b2ae5c


More information about the All-commits mailing list