[all-commits] [llvm/llvm-project] 51f743: TableGen: sort SearchableTable emission order by f...

Tim Northover via All-commits all-commits at lists.llvm.org
Tue Jan 18 04:59:54 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 51f743db08f3721fa955296fcef81cfd0c760c9b
      https://github.com/llvm/llvm-project/commit/51f743db08f3721fa955296fcef81cfd0c760c9b
  Author: Tim Northover <t.p.northover at gmail.com>
  Date:   2022-01-18 (Tue, 18 Jan 2022)

  Changed paths:
    M llvm/test/MC/AArch64/armv8r-sysreg.s
    M llvm/utils/TableGen/SearchableTableEmitter.cpp

  Log Message:
  -----------
  TableGen: sort SearchableTable emission order by fields, not top-level name

This is often used for anonymous definitions, so we were sorting by
"anonymous_1234" record names, which while less bad than pointers can be easily
perturbed by adding code even in completely unrelated systems. That causes test
failures on AArch64 when sysregs with multiple valid names suddenly start
printing a different one.




More information about the All-commits mailing list