[all-commits] [llvm/llvm-project] 2cd2ac: [clang-tidy] Fix false positives involving type al...

[FabianWolff via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2cd2accc61ea0900bde66c79d1d04b29bb9e3ed7
      https://github.com/llvm/llvm-project/commit/2cd2accc61ea0900bde66c79d1d04b29bb9e3ed7
  Author: Fabian Wolff <fabian.wolff at alumni.ethz.ch>
  Date:   2022-01-17 (Mon, 17 Jan 2022)

  Changed paths:
    M clang-tools-extra/clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp
    M clang-tools-extra/docs/clang-tidy/checks/misc-unconventional-assign-operator.rst
    M clang-tools-extra/test/clang-tidy/checkers/misc-unconventional-assign-operator.cpp

  Log Message:
  -----------
  [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

clang-tidy currently reports false positives even for simple cases such as:
```
struct S {
    using X = S;
    X &operator=(const X&) { return *this; }
};
```
This is due to the fact that the `misc-unconventional-assign-operator` check fails to look at the //canonical// types. This patch fixes this behavior.

Reviewed By: aaron.ballman, mizvekov

Differential Revision: https://reviews.llvm.org/D114197