[all-commits] [llvm/llvm-project] 875117: [clang][dataflow] Remove TestingSupport's dependen...

Yitzhak Mandelbaum via All-commits all-commits at lists.llvm.org
Mon Jan 17 07:34:46 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 875117ae7a21f0282e09a72addaf41dfd033cc55
      https://github.com/llvm/llvm-project/commit/875117ae7a21f0282e09a72addaf41dfd033cc55
  Author: Yitzhak Mandelbaum <yitzhakm at google.com>
  Date:   2022-01-17 (Mon, 17 Jan 2022)

  Changed paths:
    M clang/unittests/Analysis/FlowSensitive/MultiVarConstantPropagationTest.cpp
    M clang/unittests/Analysis/FlowSensitive/SingleVarConstantPropagationTest.cpp
    M clang/unittests/Analysis/FlowSensitive/TestingSupport.cpp
    M clang/unittests/Analysis/FlowSensitive/TestingSupport.h
    M clang/unittests/Analysis/FlowSensitive/TestingSupportTest.cpp
    M clang/unittests/Analysis/FlowSensitive/TransferTest.cpp
    M clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp

  Log Message:
  -----------
  [clang][dataflow] Remove TestingSupport's dependency on gtest

Users outside of the clang repo may use different googletest versions. So, it's
better not to depend on llvm's googletest. This patch removes the dependency by
having `checkDataflow` return an `llvm::Error` instead of calling googletest's
`FAIL` or `ASSERT...` macros.

Differential Revision: https://reviews.llvm.org/D117304




More information about the All-commits mailing list