[all-commits] [llvm/llvm-project] 12bee2: [GlobalOpt] Drop an incorrect check

Nikita Popov via All-commits all-commits at lists.llvm.org
Mon Jan 17 01:11:48 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 12bee2c0542460db8080a8630b139953207846cf
      https://github.com/llvm/llvm-project/commit/12bee2c0542460db8080a8630b139953207846cf
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-01-17 (Mon, 17 Jan 2022)

  Changed paths:
    M llvm/lib/Transforms/IPO/GlobalOpt.cpp

  Log Message:
  -----------
  [GlobalOpt] Drop an incorrect check

This was a last-minute addition to D117249, and of course I ended
up inverting the condition in a way that caused an uninitialized
memory read.

I've dropped it entirely, as I don't think we actually care whether
the size is zero or not here. The previous code wasn't checking
this either.




More information about the All-commits mailing list