[all-commits] [llvm/llvm-project] c34ada: [BOLT][CMAKE] Use IN_LIST check

Amir Aupov via All-commits all-commits at lists.llvm.org
Fri Jan 14 15:47:34 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c34adaa3ca3a80242cd5613f1ea814b66ba6076d
      https://github.com/llvm/llvm-project/commit/c34adaa3ca3a80242cd5613f1ea814b66ba6076d
  Author: Amir Ayupov <aaupov at fb.com>
  Date:   2022-01-14 (Fri, 14 Jan 2022)

  Changed paths:
    M bolt/CMakeLists.txt
    M bolt/lib/Rewrite/CMakeLists.txt
    M bolt/lib/Target/CMakeLists.txt

  Log Message:
  -----------
  [BOLT][CMAKE] Use IN_LIST check

Summary:
Address @smeenai feedback https://reviews.llvm.org/D117061#inline-1122106:
>CMake has if(IN_LIST) now, which you can use instead of the string(FIND)

IN_LIST is available since CMake 3.3 released in 2015.

Reviewed By: smeenai

FBD33590959


  Commit: 29fe14c78d044ef8f5ed5ae36a353b464ab787ec
      https://github.com/llvm/llvm-project/commit/29fe14c78d044ef8f5ed5ae36a353b464ab787ec
  Author: Amir Ayupov <aaupov at fb.com>
  Date:   2022-01-14 (Fri, 14 Jan 2022)

  Changed paths:
    M bolt/include/bolt/Rewrite/RewriteInstance.h
    M bolt/lib/Rewrite/RewriteInstance.cpp

  Log Message:
  -----------
  [BOLT][NFC] Remove redundant dependent template type

Summary:
Reduce code size by removing redundant dependent template type
from RewriteInstance methods.

Code size savings (via bloaty on llvm-bolt Debug build):
```
symbol,vmsize,filesize -> vmsize,filesize (delta vmsize,filesize)
updateELFSymbolTable         57096,59600 -> 56656,59048 (440,552)
updateELFSymbolTable::lambda 35957,55277 -> 35949,54485   (8,792)
getOutputSections            20592,21440 -> 20372,21156 (220,284)
getOutputSections::lambda      1792,5300 ->   1792,5372   (0,-72)

total delta (668,1556)
```

Reviewed By: maksfb

FBD33589393


Compare: https://github.com/llvm/llvm-project/compare/bde1032588f7...29fe14c78d04


More information about the All-commits mailing list