[all-commits] [llvm/llvm-project] 7c269d: [lld-macho] Simplify DeduplicatedCStringSection::f...

Fangrui Song via All-commits all-commits at lists.llvm.org
Fri Jan 14 13:13:14 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7c269db779ff3950bac2e25ea78b14b4e2b8b247
      https://github.com/llvm/llvm-project/commit/7c269db779ff3950bac2e25ea78b14b4e2b8b247
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-01-14 (Fri, 14 Jan 2022)

  Changed paths:
    M lld/MachO/SyntheticSections.cpp

  Log Message:
  -----------
  [lld-macho] Simplify DeduplicatedCStringSection::finalizeContents. NFC

Tail merge is slow and of low value. With regular string deduplication, we can
just use the return value of StringTableBuilder::add.

There is no noticeable performance increase because without deduplication
`__cstring` is quite small (7.6MiB for chromium_framework).

Reviewed By: #lld-macho, Jez Ng

Differential Revision: https://reviews.llvm.org/D117273




More information about the All-commits mailing list