[all-commits] [llvm/llvm-project] e0841f: [SelectionDAGBuilder] Remove unneeded vector bitca...

Craig Topper via All-commits all-commits at lists.llvm.org
Fri Jan 14 12:53:10 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e0841f692017cad1edf866e9c6907bffda5ea02c
      https://github.com/llvm/llvm-project/commit/e0841f692017cad1edf866e9c6907bffda5ea02c
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2022-01-14 (Fri, 14 Jan 2022)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

  Log Message:
  -----------
  [SelectionDAGBuilder] Remove unneeded vector bitcast from visitTargetIntrinsic.

This seems to be a leftover from a long time ago when there was
an ISD::VBIT_CONVERT and a MVT::Vector. It looks like in those days
the vector type was carried in a VTSDNode.

As far as I know, these days ComputeValueTypes would have already
assigned "Result" the same type we're getting from TLI.getValueType
here. Thus the BITCAST is always a NOP. Verified by adding an assert
and running check-llvm.

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D117335




More information about the All-commits mailing list