[all-commits] [llvm/llvm-project] 4746e3: [Libomptarget] Fix multiply defined symbol during ...

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4746e38f67a98344011e0c615a9b4c7c2f223d4e
      https://github.com/llvm/llvm-project/commit/4746e38f67a98344011e0c615a9b4c7c2f223d4e
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2022-01-13 (Thu, 13 Jan 2022)

  Changed paths:
    M openmp/libomptarget/DeviceRTL/src/Configuration.cpp
    M openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h

  Log Message:
  -----------
  [Libomptarget] Fix multiply defined symbol during linking

This patch adds the `weak` identifier to the openmp device environment
variable. The changes introduced in https://reviews.llvm.org/D117211
result in multiply defined symbols. Because the symbol is potentially
included multiple times for each offloading file we will get symbol
colisions, and because it needs to have external visiblity it should be
weak.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D117231