[all-commits] [llvm/llvm-project] 971bd6: Fix build failure with MSVC in C++20 mode

Evgeny Mandrikov via All-commits all-commits at lists.llvm.org
Thu Jan 13 03:55:41 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 971bd6f83440701cf95047b0f4e2baf75cd31c48
      https://github.com/llvm/llvm-project/commit/971bd6f83440701cf95047b0f4e2baf75cd31c48
  Author: Evgeny Mandrikov <mandrikov at gmail.com>
  Date:   2022-01-13 (Thu, 13 Jan 2022)

  Changed paths:
    M clang/include/clang/Tooling/Syntax/Tree.h

  Log Message:
  -----------
  Fix build failure with MSVC in C++20 mode

Without this patch when using CMAKE_CXX_STANDARD=20
and MSVC 19.30.30705.0 compilation fails with

clang\lib\Tooling\Syntax\Tree.cpp(347): error C2666: 'clang::syntax::Tree::ChildIteratorBase<clang::syntax::Tree::ChildIterator,clang::syntax::Node>::operator ==': 4 overloads have similar conversions
clang\lib\Tooling\Syntax\Tree.cpp(392): error C2666: 'clang::syntax::Tree::ChildIteratorBase<clang::syntax::Tree::ChildIterator,clang::syntax::Node>::operator ==': 4 overloads have similar conversions

Note that removed comment that
"iterator_facade_base requires == to be a member"
was made obsolete by change https://reviews.llvm.org/D78938

Reviewed By: sammccall

Differential Revision: https://reviews.llvm.org/D116904




More information about the All-commits mailing list