[all-commits] [llvm/llvm-project] 56f62f: [mlir] Finish removing Identifier from the C++ API

River Riddle via All-commits all-commits at lists.llvm.org
Wed Jan 12 11:59:03 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 56f62fbf73a2c0844d7f26ae10f2757aac981a2d
      https://github.com/llvm/llvm-project/commit/56f62fbf73a2c0844d7f26ae10f2757aac981a2d
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-01-12 (Wed, 12 Jan 2022)

  Changed paths:
    M cross-project-tests/debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.cpp
    M flang/lib/Lower/FIRBuilder.cpp
    M flang/lib/Optimizer/Builder/FIRBuilder.cpp
    M flang/unittests/Optimizer/Builder/FIRBuilderTest.cpp
    M mlir/include/mlir/IR/Attributes.h
    M mlir/include/mlir/IR/Builders.h
    M mlir/include/mlir/IR/BuiltinAttributes.td
    R mlir/include/mlir/IR/Identifier.h
    M mlir/lib/CAPI/IR/IR.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
    M mlir/lib/IR/Builders.cpp
    M mlir/lib/Pass/Pass.cpp
    M mlir/test/lib/Dialect/Linalg/TestLinalgDistribution.cpp

  Log Message:
  -----------
  [mlir] Finish removing Identifier from the C++ API

There have been a few API pieces remaining to allow for a smooth transition for
downstream users, but these have been up for a few months now. After this only
the C API will have reference to "Identifier", but those will be reworked in a followup.

The main updates are:
* Identifier -> StringAttr
* StringAttr::get requires the context as the first parameter
  - i.e. `Identifier::get("...", ctx)` -> `StringAttr::get(ctx, "...")`

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D116626




More information about the All-commits mailing list