[all-commits] [llvm/llvm-project] 091e76: [lldb] Don't print "Command Options Usage:" for an...

David Spickett via All-commits all-commits at lists.llvm.org
Wed Jan 12 02:07:50 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 091e760cd39848f3c41900b5104b3d92028d91b4
      https://github.com/llvm/llvm-project/commit/091e760cd39848f3c41900b5104b3d92028d91b4
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2022-01-12 (Wed, 12 Jan 2022)

  Changed paths:
    M lldb/source/Interpreter/Options.cpp
    M lldb/test/API/commands/platform/basic/TestPlatformCommand.py

  Log Message:
  -----------
  [lldb] Don't print "Command Options Usage:" for an alias with no options

"shell" is an alias to "platform shell -h --". Previously you would get this
help text:

(lldb) help shell
Run a shell command on the host.  Expects 'raw' input (see 'help raw-input'.)

Syntax: shell <shell-command>

Command Options Usage:

'shell' is an abbreviation for 'platform shell -h   --'

Since the code doesn't handle the base command having options
but the alias removing them. With these changes you get:

(lldb) help shell
Run a shell command on the host.  Expects 'raw' input (see 'help raw-input'.)

Syntax: shell <shell-command>

'shell' is an abbreviation for 'platform shell -h   --'

Note that we already handle a non-alias command having no options,
for example "quit":

(lldb) help quit
Quit the LLDB debugger.

Syntax: quit [exit-code]

Reviewed By: JDevlieghere, jingham

Differential Revision: https://reviews.llvm.org/D117004




More information about the All-commits mailing list