[all-commits] [llvm/llvm-project] f5b387: Revert "[CodeGen] Mark fma as const for Android"

Alex Xu via All-commits all-commits at lists.llvm.org
Mon Jan 10 11:35:37 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f5b387988bd4885a973f35deaf3881524f526e3f
      https://github.com/llvm/llvm-project/commit/f5b387988bd4885a973f35deaf3881524f526e3f
  Author: Alex Xu (Hello71) <alex_y_xu at yahoo.ca>
  Date:   2022-01-10 (Mon, 10 Jan 2022)

  Changed paths:
    M clang/lib/Sema/SemaDecl.cpp
    M clang/test/CodeGen/math-builtins.c

  Log Message:
  -----------
  Revert "[CodeGen] Mark fma as const for Android"

This code is intended to give a special exception for platforms which set errno in some math functions but not fma. This does not apply to Android, which does not set errno in any math functions (https://cs.android.com/android/platform/superproject/+/master:bionic/libc/include/math.h;drc=master;l=59). The correct implementation for Android is to set -fno-math-errno by default, which was done in https://reviews.llvm.org/D51068. Therefore, this special exception is no longer needed for Android. Deleting it slightly reduces code complexity, clang executable size, compile time, and test time.

This reverts fbfba29d74748b8fffd2f7cc654fb4c3659c8f67.

Reviewed By: pirama

Differential Revision: https://reviews.llvm.org/D116755




More information about the All-commits mailing list