[all-commits] [llvm/llvm-project] 353484: [LowerExpectIntrinsic] Use cast<> instead of dyn_c...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Mon Jan 10 07:35:45 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 353484d191f6518e5f65b73f1d50db8cae0c1a6c
      https://github.com/llvm/llvm-project/commit/353484d191f6518e5f65b73f1d50db8cae0c1a6c
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-01-10 (Mon, 10 Jan 2022)

  Changed paths:
    M llvm/lib/Transforms/Scalar/LowerExpectIntrinsic.cpp

  Log Message:
  -----------
  [LowerExpectIntrinsic] Use cast<> instead of dyn_cast<> to avoid dereference of nullptr. NFC


  Commit: c1f13598822d57ce4c0c2589587c2bd97c99f42f
      https://github.com/llvm/llvm-project/commit/c1f13598822d57ce4c0c2589587c2bd97c99f42f
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-01-10 (Mon, 10 Jan 2022)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp

  Log Message:
  -----------
  [PGOInstrumentation] populateEHOperandBundle - earlyout if !isa<CallBase>

All paths (that actually do anything) require a successful dyn_cast<CallBase> - so just earlyout if the cast fails

Fixes static analyzer nullptr deference warning


Compare: https://github.com/llvm/llvm-project/compare/8ccfcab34ffb...c1f13598822d


More information about the All-commits mailing list