[all-commits] [llvm/llvm-project] 2c7d10: [lldb] Set result error state in 'frame variable'

Dave Lee via All-commits all-commits at lists.llvm.org
Sat Jan 8 08:50:50 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2c7d10c41278181e3e45c68f28b501cd95193a8a
  Author: Dave Lee <davelee.com at gmail.com>
  Date:   2022-01-08 (Sat, 08 Jan 2022)

  Changed paths:
    M lldb/source/Commands/CommandObjectFrame.cpp

  Log Message:
  [lldb] Set result error state in 'frame variable'

Ensure that errors in `frame variable` are reflected in result object.

The statistics for `frame variable` show invocations as being successful, even
when executing one of the error paths.

This change replaces `result.GetErrorStream()` with `result.AppendError()`,
which also sets the status to `eReturnStatusFailed`.

Differential Revision: https://reviews.llvm.org/D116788

More information about the All-commits mailing list