[all-commits] [llvm/llvm-project] cb992f: Make separate config variable for `LLVM_LIBRARY_DIRS`

John Ericson via All-commits all-commits at lists.llvm.org
Fri Jan 7 15:54:44 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cb992f9158319a5cf079e53805f81badc609ef0f
  Author: John Ericson <John.Ericson at Obsidian.Systems>
  Date:   2022-01-07 (Fri, 07 Jan 2022)

  Changed paths:
    M llvm/cmake/modules/CMakeLists.txt
    M llvm/cmake/modules/LLVMConfig.cmake.in

  Log Message:
  Make separate config variable for `LLVM_LIBRARY_DIRS`

@beanz tells me it should in fact exists, and it would be bad to put a
list of dirs in `LLVM_LIBRARY_DIR`. I am therefore making some changes
to help avoid this an other mistakes:

- Use a separate `LLVM_CONFIG_LIBRARY_DIR` (no "S") variable so we don't
  start putting a list in `LLVM_LIBRARY_DIR` by mistake.

- Define the individual dir variables first, and the define the list of
  dirs variables programmatically.

Also, I rearranged the definitions of the "regular" single dirs below so
`LLVM_BINARY_DIR`, which is the unsuffixed one, comes first before the
suffixed ones.

Reviewed By: beanz

Differential Revision: https://reviews.llvm.org/D116497

More information about the All-commits mailing list