[all-commits] [llvm/llvm-project] 4f6d3a: [LLDB] Fix setting of success in Socket::Close()

Shafik Yaghmour via All-commits all-commits at lists.llvm.org
Fri Jan 7 12:43:14 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4f6d3a376c9faba93bbdf105966cea7585b0b8e9
      https://github.com/llvm/llvm-project/commit/4f6d3a376c9faba93bbdf105966cea7585b0b8e9
  Author: Shafik Yaghmour <syaghmour at apple.com>
  Date:   2022-01-07 (Fri, 07 Jan 2022)

  Changed paths:
    M lldb/source/Host/common/Socket.cpp

  Log Message:
  -----------
  [LLDB] Fix setting of success in Socket::Close()

Both close and closesocket should return 0 on success so using !! looks incorrect. I replaced this will a more readable == 0 check.

Differential Revision: https://reviews.llvm.org/D116768




More information about the All-commits mailing list