[all-commits] [llvm/llvm-project] 4ca5e9: [mlir] Symbol DCE ignores unknown symbols

Jeff Niu via All-commits all-commits at lists.llvm.org
Wed Jan 5 12:48:43 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4ca5e95c6f4e8f48cd8315d801c186f4e7cae69c
  Author: Mogball <jeffniu22 at gmail.com>
  Date:   2022-01-05 (Wed, 05 Jan 2022)

  Changed paths:
    M mlir/lib/Transforms/SymbolDCE.cpp
    M mlir/test/Transforms/test-symbol-dce.mlir

  Log Message:
  [mlir] Symbol DCE ignores unknown symbols

Instead of failing when it encounters a reference to an unknown symbol, Symbol DCE should ignore them. References to unknown symbols do not affect the overall function of Symbol DCE, so it should not need to fail when it encounters one.

In general, requiring that symbol references always be valid rather than only when necessary can be overly conservative.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D116047

More information about the All-commits mailing list