[all-commits] [llvm/llvm-project] bb2f87: [mlir] Fix missing check on nested op values in LICM

Nicolas Vasilache via All-commits all-commits at lists.llvm.org
Wed Jan 5 06:32:57 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bb2f87af0ac9ad8cc0efcb523e108e715ee9ab93
  Author: Nicolas Vasilache <ntv at google.com>
  Date:   2022-01-05 (Wed, 05 Jan 2022)

  Changed paths:
    M mlir/lib/Transforms/LoopInvariantCodeMotion.cpp
    M mlir/test/Transforms/loop-invariant-code-motion.mlir

  Log Message:
  [mlir] Fix missing check on nested op values in LICM

LICM checks that nested ops depend only on values defined outside
before performing hoisting.
However, it specifically omits to check for terminators which can
lead to SSA violations.
This revision fixes the incorrect behavior.

Differential Revision: https://reviews.llvm.org/D116657

More information about the All-commits mailing list