[all-commits] [llvm/llvm-project] 67b5bc: [DebugInfo] Check DIEnumerator bit width when comp...

aeubanks via All-commits all-commits at lists.llvm.org
Tue Jan 4 21:59:43 PST 2022

  Branch: refs/heads/release/13.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 67b5bc26bde81a60688ae5c049a001ffbc6dd614
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2022-01-04 (Tue, 04 Jan 2022)

  Changed paths:
    M llvm/lib/IR/LLVMContextImpl.h
    M llvm/unittests/IR/DebugInfoTest.cpp

  Log Message:
  [DebugInfo] Check DIEnumerator bit width when comparing for equality

As mentioned in D106585, this causes non-determinism, which can also be
shown by this test case being flaky without this patch.

We were using the APSInt's bit width for hashing, but not for checking
for equality. APInt::isSameValue() does not check bit width.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D115054

(cherry picked from commit 93a20ecee4b6c6618e0a8e1112f4f929d55ffcbb)

More information about the All-commits mailing list