[all-commits] [llvm/llvm-project] 949bbd: [CMake] Use `LLVM_COMMON_CMAKE_UTILS` in runtimes ...

John Ericson via All-commits all-commits at lists.llvm.org
Mon Jan 3 12:55:56 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 949bbd0a689286d0b2f73ae4f212673bc0bd688c
  Author: John Ericson <John.Ericson at Obsidian.Systems>
  Date:   2022-01-03 (Mon, 03 Jan 2022)

  Changed paths:
    M compiler-rt/CMakeLists.txt
    M compiler-rt/lib/builtins/CMakeLists.txt
    M libcxx/CMakeLists.txt
    M libcxxabi/CMakeLists.txt
    M libunwind/CMakeLists.txt
    M runtimes/CMakeLists.txt

  Log Message:
  [CMake] Use `LLVM_COMMON_CMAKE_UTILS` in runtimes just for clarity

In D116472 we created conditionally defined variables for the tools to
unbreak the legacy build where they are in `llvm/tools`.

The runtimes are not tools, so that flexibility doesn't matter. Still,
it might be nice to define (unconditionally) and use the variable for
the runtimes simply to make the code a bit clearer and document what is
going on.

Also, consistently put project dirs at the beginning, not end of `CMAKE_MODULE_PATH`. This ensures they will properly shadow similarly named stuff that happens to be later on the path.

Reviewed By: mstorsjo, #libunwind, #libc, #libc_abi, ldionne

Differential Revision: https://reviews.llvm.org/D116477

More information about the All-commits mailing list