[all-commits] [llvm/llvm-project] a3ab2c: [clang][cmake] Rearrange top-level CMakeLists.txt ...

John Ericson via All-commits all-commits at lists.llvm.org
Mon Jan 3 10:28:46 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a3ab2c94a2715c45e39abdb36b4d78e028b051d2
  Author: John Ericson <John.Ericson at Obsidian.Systems>
  Date:   2022-01-03 (Mon, 03 Jan 2022)

  Changed paths:
    M clang/CMakeLists.txt

  Log Message:
  [clang][cmake] Rearrange top-level CMakeLists.txt for D116492

In that revision, I make LLD match Clang in deprecating `llvm-config`.
This patch isn't to worthwhile on its own --- there isn't a sense in
which the new order is "better" in isolation --- but by putting the
steps that LLD also neeeds to do first, I make the diff between LLD and
Clang's top-level `CMakeLists.txt` very legible.

Longer term I hope:

 1. We can remove calling `llvm-config` altogether, and just go strait to
    finding the CMake config file. This is what Flang does, at least.

 2. Hopefully the diffable part is smaller then --- i.e. there is less
    duplicated boilerplate.

 3. Any duplicate boilerplate that remains can be factored out.

I didn't both trying to factor anything out in e.g. the top level common
CMake Utility modules because this deprecated-but-not-removed state is a
merely transitional.

Reviewed By: beanz

Differential Revision: https://reviews.llvm.org/D116548

More information about the All-commits mailing list