[all-commits] [llvm/llvm-project] e49c0e: [MLIR] Fix confusing diagnostic during dialect con...

[Uday Bondhugula via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e49c0e483fd751aa60c943eb9f573e4bd28d2a47
      https://github.com/llvm/llvm-project/commit/e49c0e483fd751aa60c943eb9f573e4bd28d2a47
  Author: Uday Bondhugula <uday at polymagelabs.com>
  Date:   2022-01-03 (Mon, 03 Jan 2022)

  Changed paths:
    M mlir/docs/DialectConversion.md
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [MLIR] Fix confusing diagnostic during dialect conversion

Fix confusing diagnostic during partial dialect conversion. A failure to
legalize is not the same as an operation being illegal: for eg. an
operation neither explicity marked legal nor explicitly marked illegal
could have been generated and may have failed to legalize further. The
op isn't an illegal one per
https://mlir.llvm.org/docs/DialectConversion/#conversion-target
which is an op that is explicitly marked illegal.

Differential Revision: https://reviews.llvm.org/D116152