[all-commits] [llvm/llvm-project] a5a24c: Remove misused RAII gil_scoped_release/gil_scoped_...

Mehdi Amini via All-commits all-commits at lists.llvm.org
Sun Jan 2 22:19:53 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a5a24c93706d5cf67ccaaaeb1b7ac13a801275b4
      https://github.com/llvm/llvm-project/commit/a5a24c93706d5cf67ccaaaeb1b7ac13a801275b4
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2022-01-03 (Mon, 03 Jan 2022)

  Changed paths:
    M mlir/lib/Bindings/Python/IRCore.cpp
    M mlir/lib/Bindings/Python/IRModule.cpp

  Log Message:
  -----------
  Remove misused RAII gil_scoped_release/gil_scoped_acquire: without name they don't have any effect

I'm not sure what is the right fix here, but adding a name to all these
lead to many segfaults.

Reviewed By: stellaraccident

Differential Revision: https://reviews.llvm.org/D116506


  Commit: 78389de4d396ee180aa87174b78996d4a83ae819
      https://github.com/llvm/llvm-project/commit/78389de4d396ee180aa87174b78996d4a83ae819
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2022-01-03 (Mon, 03 Jan 2022)

  Changed paths:
    M mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp

  Log Message:
  -----------
  Add back missing return to non-void function

It was incorrectly removed accidentally in e4e463e7476.


Compare: https://github.com/llvm/llvm-project/compare/29120a51307c...78389de4d396


More information about the All-commits mailing list