[all-commits] [llvm/llvm-project] a6a583: [MLIR] Move AtomicRMW into MemRef dialect and enum...

William Moses via All-commits all-commits at lists.llvm.org
Thu Dec 30 11:31:45 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a6a583dae40485cacfac56811e6d9131bac6ca74
      https://github.com/llvm/llvm-project/commit/a6a583dae40485cacfac56811e6d9131bac6ca74
  Author: William S. Moses <gh at wsmoses.com>
  Date:   2021-12-30 (Thu, 30 Dec 2021)

  Changed paths:
    M mlir/include/mlir/Analysis/AffineAnalysis.h
    M mlir/include/mlir/Dialect/Affine/IR/AffineOps.td
    M mlir/include/mlir/Dialect/Arithmetic/IR/Arithmetic.h
    M mlir/include/mlir/Dialect/Arithmetic/IR/ArithmeticBase.td
    M mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
    M mlir/include/mlir/Dialect/StandardOps/IR/Ops.h
    M mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
    R mlir/include/mlir/Dialect/StandardOps/IR/StandardOpsBase.td
    M mlir/include/mlir/Dialect/Vector/VectorOps.h
    M mlir/lib/Analysis/AffineAnalysis.cpp
    M mlir/lib/Conversion/AffineToStandard/AffineToStandard.cpp
    M mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp
    M mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
    M mlir/lib/Dialect/Affine/IR/AffineOps.cpp
    M mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp
    M mlir/lib/Dialect/Arithmetic/IR/ArithmeticOps.cpp
    M mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
    M mlir/lib/Dialect/StandardOps/IR/Ops.cpp
    M mlir/lib/Dialect/StandardOps/Transforms/ExpandOps.cpp
    M mlir/lib/Dialect/Vector/VectorOps.cpp
    M mlir/lib/Transforms/Utils/LoopUtils.cpp
    M mlir/test/Conversion/MemRefToLLVM/memref-to-llvm.mlir
    M mlir/test/Conversion/StandardToLLVM/standard-to-llvm.mlir
    M mlir/test/Dialect/MemRef/canonicalize.mlir
    M mlir/test/Dialect/MemRef/invalid.mlir
    M mlir/test/Dialect/MemRef/ops.mlir
    M mlir/test/Dialect/Standard/expand-ops.mlir
    M mlir/test/IR/core-ops.mlir
    M mlir/test/IR/invalid-ops.mlir

  Log Message:
  -----------
  [MLIR] Move AtomicRMW into MemRef dialect and enum into Arith

Per the discussion in https://reviews.llvm.org/D116345 it makes sense
to move AtomicRMWOp out of the standard dialect. This was accentuated by the
need to add a fold op with a memref::cast. The only dialect
that would permit this is the memref dialect (keeping it in the standard dialect
or moving it to the arithmetic dialect would require those dialects to have a
dependency on the memref dialect, which breaks linking).

As the AtomicRMWKind enum is used throughout, this has been moved to Arith.

Reviewed By: Mogball

Differential Revision: https://reviews.llvm.org/D116392




More information about the All-commits mailing list