[all-commits] [llvm/llvm-project] a5337d: [BitcodeReader] `bitc::CST_CODE_INLINEASM`: un-har...

[Roman Lebedev via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a5337d6a1c6701eb98e085fb69a6e33c36f9533f
      https://github.com/llvm/llvm-project/commit/a5337d6a1c6701eb98e085fb69a6e33c36f9533f
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2021-12-30 (Thu, 30 Dec 2021)

  Changed paths:
    M llvm/lib/Bitcode/Reader/BitcodeReader.cpp

  Log Message:
  -----------
  [BitcodeReader] `bitc::CST_CODE_INLINEASM`: un-hardcode offsets


  Commit: 62b1682570b1059e8c6542192159dcde32c13c30
      https://github.com/llvm/llvm-project/commit/62b1682570b1059e8c6542192159dcde32c13c30
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2021-12-30 (Thu, 30 Dec 2021)

  Changed paths:
    M llvm/include/llvm/Bitcode/LLVMBitCodes.h
    M llvm/lib/Bitcode/Reader/BitcodeReader.cpp
    M llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
    M llvm/test/Bitcode/callbr.ll

  Log Message:
  -----------
  [Opaqueptrs][IR Serialization] Improve inlineasm [de]serialization

The bitcode reader expected that the pointers are typed,
so that it can extract the function type for the assembly
so `bitc::CST_CODE_INLINEASM` did not explicitly store said function type.

I'm not really sure how the upgrade path will look for existing bitcode,
but i think we can easily support opaque pointers going forward,
by simply storing the function type.

Reviewed By: #opaque-pointers, nikic

Differential Revision: https://reviews.llvm.org/D116341


Compare: https://github.com/llvm/llvm-project/compare/128c6ed73b8f...62b1682570b1