[all-commits] [llvm/llvm-project] 6edc38: DWARFDie: don't try to compute a full template nam...

David Blaikie via All-commits all-commits at lists.llvm.org
Wed Dec 29 14:09:19 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6edc38935aaf98c2ee2e87874330b9dc08d899ab
      https://github.com/llvm/llvm-project/commit/6edc38935aaf98c2ee2e87874330b9dc08d899ab
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2021-12-29 (Wed, 29 Dec 2021)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFDie.cpp

  Log Message:
  -----------
  DWARFDie: don't try to compute a full template name for a template parameter packs

Otherwise these look a lot like actual templates (they have a name and
they have template parameters) but they don't participate in naming
(this doesn't come up in practice because a template parameter pack DIE
is never referenced from another DIE (so we don't do full name
rebuilding for it) or the subject of simplified template name rebuilding
(never has the _STN prefix)) - it could be tested with some hand crafted
DWARF but doesn't seem important/useful to do so.

This change is just for performance - to avoid trying to parse more
DIEs, etc, when it's not needed when computing the name in the DWARF
verifier.




More information about the All-commits mailing list