[all-commits] [llvm/llvm-project] c95753: [NFC][X86] Add MC tests for all untested VIA PadLo...

Jessica Clarke via All-commits all-commits at lists.llvm.org
Tue Dec 21 17:10:05 PST 2021


  Branch: refs/heads/release/13.x
  Home:   https://github.com/llvm/llvm-project
  Commit: c95753ff5c116134a5ff8029cf2c35c8b760a027
      https://github.com/llvm/llvm-project/commit/c95753ff5c116134a5ff8029cf2c35c8b760a027
  Author: Jessica Clarke <jrtc27 at jrtc27.com>
  Date:   2021-12-21 (Tue, 21 Dec 2021)

  Changed paths:
    M llvm/test/MC/X86/padlock.s

  Log Message:
  -----------
  [NFC][X86] Add MC tests for all untested VIA PadLock instructions

We currently only test the encoding of xstore but none of the other
instructions, which should all have their implicit REP prefix be
verified as working.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D112354

(cherry picked from commit b432583d28ee99313fa834139be9535639957d76)


  Commit: ae24102617c9c86552807a598fe6521ca9c6d7ee
      https://github.com/llvm/llvm-project/commit/ae24102617c9c86552807a598fe6521ca9c6d7ee
  Author: Jessica Clarke <jrtc27 at jrtc27.com>
  Date:   2021-12-21 (Tue, 21 Dec 2021)

  Changed paths:
    M llvm/lib/Target/X86/X86InstrSystem.td
    M llvm/test/MC/X86/padlock.s

  Log Message:
  -----------
  [X86] Don't add implicit REP prefix to VIA PadLock xstore

Commit 8fa3e8fa1492 added an implicit REP prefix to all VIA PadLock
instructions, but GNU as doesn't add one to xstore, only all the others.
This resulted in a kernel panic regression in FreeBSD upon updating to
LLVM 11 (https://bugs.freebsd.org/259218) which includes the commit in
question. This partially reverts that commit.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D112355

(cherry picked from commit 2d8c18fbbdd1b07ab0d36ac49ef63f4d243afb8b)


Compare: https://github.com/llvm/llvm-project/compare/d9f927f2cfe8...ae24102617c9


More information about the All-commits mailing list