[all-commits] [llvm/llvm-project] 555eac: [clangd] Fix undefined behavior when generating er...

[Aleksandr Platonov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 555eacf75f21cd1dfc6363d73ad187b730349543
      https://github.com/llvm/llvm-project/commit/555eacf75f21cd1dfc6363d73ad187b730349543
  Author: Aleksandr Platonov <platonov.aleksandr at huawei.com>
  Date:   2021-12-19 (Sun, 19 Dec 2021)

  Changed paths:
    M clang-tools-extra/clangd/refactor/Rename.cpp
    M clang-tools-extra/clangd/unittests/RenameTests.cpp

  Log Message:
  -----------
  [clangd] Fix undefined behavior when generating error message at rename with an invalid name

`Message()` lambda uses `Reason.Details` as an input parameter for `llvm::formatv()`, but `Reason` in `Message()` is a local object.
Return value of `llvm::formatv()` contains references to its input arguments, thus `Message()` returns an object which contains a reference to `Details` field of the local object `Reason`.
This patch fixes this behavior by passing `Reason` as a reference to `Message()` to ensure that return value of `Message()` contains references to alive object and also prevents copying of `InvalidName` structure at passing it to `makeError()`.

Provided test passes on Linux+GCC with or without this patch, but fails on Windows+VisualStudio without this patch.

Reviewed By: sammccall

Differential Revision: https://reviews.llvm.org/D115959