[all-commits] [llvm/llvm-project] c50a4b: [Modules] Incorrect ODR detection for unresolved u...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Thu Dec 16 18:38:36 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c50a4b3f97497c27ad62797080b52f501dac5e38
      https://github.com/llvm/llvm-project/commit/c50a4b3f97497c27ad62797080b52f501dac5e38
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2021-12-17 (Fri, 17 Dec 2021)

  Changed paths:
    M clang/include/clang/AST/ASTContext.h
    M clang/include/clang/AST/TypeProperties.td
    M clang/lib/AST/ASTContext.cpp
    A clang/test/Modules/Inputs/odr_using_dependent_name/X.cppm
    A clang/test/Modules/Inputs/odr_using_dependent_name/foo.h
    A clang/test/Modules/odr_using_dependent_name.cppm

  Log Message:
  -----------
  [Modules] Incorrect ODR detection for unresolved using type

Implement `getUnresolvedUsingType()` and don't create a new
`UnresolvedUsingType` when there is already canonical declaration.

This solved an incorrect ODR detection in modules for uresolved using
type.

Reviewed By: rjmccall

Differential Revision: https://reviews.llvm.org/D115792




More information about the All-commits mailing list