[all-commits] [llvm/llvm-project] dcf11a: [Sanitizer] Disable LSan when testing on iOS simul...

[Julian Lettner via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dcf11af24beff812c18ccd7f714028aedbdfc5e0
      https://github.com/llvm/llvm-project/commit/dcf11af24beff812c18ccd7f714028aedbdfc5e0
  Author: Julian Lettner <julian.lettner at apple.com>
  Date:   2021-12-16 (Thu, 16 Dec 2021)

  Changed paths:
    M compiler-rt/test/asan/lit.cfg.py

  Log Message:
  -----------
  [Sanitizer] Disable LSan when testing on iOS simulators

LSan (`ASAN_OPTIONS=detect_leaks=1`) is supported on macOS, but disabled
by default on Darwin (`SANITIZER_MAC`):
```
COMMON_FLAG(bool, detect_leaks, !SANITIZER_MAC, "Enable memory leak detection.")
```

We enable it here for ASan tests to prevent regressions (per comment).
However, LSan is not supported for the iOS simulator and the tests fail
when it is enabled.

Make this "Is macOS?" check more precise since the current one (`Darwin
&& x86_64`) has two issues:
 * Includes the simulators
 * Excludes macOS on Apple Silicon

This will allow us to (re)enable simulator testing on Green dragon to
give open source better feedback about sanitizer changes:
https://green.lab.llvm.org

rdar://86529234

Differential Revision: https://reviews.llvm.org/D115816