[all-commits] [llvm/llvm-project] ec37e0: Re-apply "Only define LLVM_EXTERNAL_VISIBILITY whe...

[Ben Langmuir via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ec37e0bbafab75fa64f1ddb4cdeceb5400491ef8
      https://github.com/llvm/llvm-project/commit/ec37e0bbafab75fa64f1ddb4cdeceb5400491ef8
  Author: Ben Langmuir <blangmuir at apple.com>
  Date:   2021-12-16 (Thu, 16 Dec 2021)

  Changed paths:
    M llvm/CMakeLists.txt
    M llvm/include/llvm/Config/llvm-config.h.cmake
    M llvm/include/llvm/Support/Compiler.h

  Log Message:
  -----------
  Re-apply "Only define LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib"

With a fix for BUILD_SHARED_LIBS.

Original commit message:

When building LLVM static libraries, we should not make symbols more
visible than CMAKE_CXX_VISIBILITY_PRESET, since the goal may be to have
a purely hidden llvm embedded in another library. Instead, we only
define LLVM_EXTERNAL_VISIBILITY for the dynamic library build (when
LLVM_BUILD_LLVM_DYLIB=YES or BUILD_SHARED_LIBS=YES).

Original Review: https://reviews.llvm.org/D113610

Differential Revision: https://reviews.llvm.org/D115825