[all-commits] [llvm/llvm-project] a7cbe1: [Darwin] Remove workaround for symbolication in iO...

Julian Lettner via All-commits all-commits at lists.llvm.org
Wed Dec 15 17:23:51 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a7cbe198cea40e0b5bc8749bb3813bbfc704d70b
      https://github.com/llvm/llvm-project/commit/a7cbe198cea40e0b5bc8749bb3813bbfc704d70b
  Author: Julian Lettner <julian.lettner at apple.com>
  Date:   2021-12-15 (Wed, 15 Dec 2021)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.cpp
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.h
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_internal.h
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cpp
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.h
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup.cpp
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cpp
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_win.cpp

  Log Message:
  -----------
  [Darwin] Remove workaround for symbolication in iOS simulator runtimes

A while ago we added some code to the sanitizer runtimes for iOS
simulators to allow `atos` (external process) to inspect the sanitized
process during report generation to enable symbolication.  This was done
by setting the `__check_mach_ports_lookup` env var early during process
startup which came with a couple of complications.

This workaround is not required anymore and removing it fixes TSan in
the iOS simulator after the new TSan runtime landed.
(https://reviews.llvm.org/D112603)

Relevant/reverted revisions:
https://reviews.llvm.org/D78178
https://reviews.llvm.org/D78179
https://reviews.llvm.org/D78525

rdar://86472733

Differential Revision: https://reviews.llvm.org/D115767




More information about the All-commits mailing list