[all-commits] [llvm/llvm-project] d17b09: [lld-macho] Make writing map file asynchronous

Vincent Lee via All-commits all-commits at lists.llvm.org
Wed Dec 15 16:41:34 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d17b092fe690e98bc366a2341e050e4fd616e810
      https://github.com/llvm/llvm-project/commit/d17b092fe690e98bc366a2341e050e4fd616e810
  Author: Vincent Lee <leevince at fb.com>
  Date:   2021-12-15 (Wed, 15 Dec 2021)

  Changed paths:
    M lld/MachO/Writer.cpp

  Log Message:
  -----------
  [lld-macho] Make writing map file asynchronous

For large applications that write to map files, writing map files can take quite
a bit of time. Sorting the biggest contributors to link times, writing map files
ranks in at 2nd place, with load input files being the biggest contributor of
link times. Avoiding writing map files on the critical path (and having its own
thread) saves ~2-3 seconds when linking chromium framework on a 16-Core
Intel Xeon W.

```
           base            diff            difference (95% CI)
sys_time   1.617 ± 0.034   1.657 ± 0.026   [  +1.5% ..   +3.5%]
user_time  28.536 ± 0.245  28.609 ± 0.180  [  -0.1% ..   +0.7%]
wall_time  23.833 ± 0.271  21.684 ± 0.194  [  -9.5% ..   -8.5%]
samples    31              24
```

Reviewed By: #lld-macho, oontvoo, int3

Differential Revision: https://reviews.llvm.org/D115416




More information about the All-commits mailing list