[all-commits] [llvm/llvm-project] 0d1363: Revert "[Sema] Mark explicit specialization declar...

Yuanfang Chen via All-commits all-commits at lists.llvm.org
Wed Dec 15 10:27:28 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0d1363e5614e24d164373e19e3f4b7102188d4e3
      https://github.com/llvm/llvm-project/commit/0d1363e5614e24d164373e19e3f4b7102188d4e3
  Author: Yuanfang Chen <yuanfang.chen at sony.com>
  Date:   2021-12-15 (Wed, 15 Dec 2021)

  Changed paths:
    M clang/lib/Sema/SemaDecl.cpp
    R clang/test/CXX/temp/temp.spec/temp.expl.spec/p20-2.cpp

  Log Message:
  -----------
  Revert "[Sema] Mark explicit specialization declaration in a friend invalid"

This reverts commit 8cb6ecbc4da2b0cfd8dcf04f612dc413716d27a1.

Nothing wrong with the commit. It is missing Phabricator informations.


  Commit: 1510595dce9c48b9e7ddd49becd422c4e5e66fc9
      https://github.com/llvm/llvm-project/commit/1510595dce9c48b9e7ddd49becd422c4e5e66fc9
  Author: Yuanfang Chen <yuanfang.chen at sony.com>
  Date:   2021-12-15 (Wed, 15 Dec 2021)

  Changed paths:
    M clang/lib/Sema/SemaDecl.cpp
    A clang/test/CXX/temp/temp.spec/temp.expl.spec/p20-2.cpp

  Log Message:
  -----------
  [Sema] Mark explicit specialization declaration in a friend invalid

Down the path, if there is a implicit instantiation, this may trigger
the assertion "Member specialization must be an explicit specialization"
in `clang::FunctionDecl::setFunctionTemplateSpecialization`.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D113245


Compare: https://github.com/llvm/llvm-project/compare/8cb6ecbc4da2...1510595dce9c


More information about the All-commits mailing list