[all-commits] [llvm/llvm-project] 3031fd: [clang][deps] NFC: Use clearer wording around entr...

[Jan Svoboda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3031fd71b91433f02f6dd8072a7d99ff24e8aad8
      https://github.com/llvm/llvm-project/commit/3031fd71b91433f02f6dd8072a7d99ff24e8aad8
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2021-12-15 (Wed, 15 Dec 2021)

  Changed paths:
    M clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h
    M clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp

  Log Message:
  -----------
  [clang][deps] NFC: Use clearer wording around entry initialization

The code and documentation around `CachedFileSystemEntry` use the following terms:
* "invalid stat" for `llvm::ErrorOr<llvm::vfs::Status>` that is *not* an error and contains an unknown status,
* "initialized entry" for an entry that contains "invalid stat",
* "valid entry" for an entry that contains "invalid stat", synonymous to "initialized" entry.

Having an entry be "valid" while it contains an "invalid" status object is counter-intuitive.
This patch cleans up the wording by referring to the status as "unknown" and to the entry as either "initialized" or "uninitialized".