[all-commits] [llvm/llvm-project] 92f2d0: DebugInfo: Sink string form validation down from v...

[David Blaikie via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 92f2d02b4a315eb91cd59e90394c0805123a96fa
      https://github.com/llvm/llvm-project/commit/92f2d02b4a315eb91cd59e90394c0805123a96fa
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2021-12-14 (Tue, 14 Dec 2021)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFFormValue.h
    M llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h
    M llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
    M llvm/test/DebugInfo/X86/debug-macro-empty-str-offset.s
    M llvm/test/tools/llvm-dwarfdump/X86/verify_invalid_strp.yaml

  Log Message:
  -----------
  DebugInfo: Sink string form validation down from verifier to form parsing

Avoid duplicating the string decoding - improve the error messages down
in form parsing (& produce an Expected<const char*> instead of
Optional<const char*> to communicate the extra error details)