[all-commits] [llvm/llvm-project] c57b2a: [MLIR][GPU] Make max flat work group size for ROCD...

Krzysztof Drewniak via All-commits all-commits at lists.llvm.org
Tue Dec 14 12:12:35 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c57b2a0635df9eae0b1d699f83b9b158d5a89135
      https://github.com/llvm/llvm-project/commit/c57b2a0635df9eae0b1d699f83b9b158d5a89135
  Author: Krzysztof Drewniak <Krzysztof.Drewniak at amd.com>
  Date:   2021-12-14 (Tue, 14 Dec 2021)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/ROCDL/ROCDLToLLVMIRTranslation.cpp
    M mlir/test/Target/LLVMIR/rocdl.mlir

  Log Message:
  -----------
  [MLIR][GPU] Make max flat work group size for ROCDL kernels configurable

While the default value for the amdgpu-flat-work-group-size attribute,
"1, 256", matches the defaults from Clang, some users of the ROCDL dialect,
namely Tensorflow, use larger workgroups, such as 1024. Therefore,
instead of hardcoding this value, we add a rocdl.max_flat_work_group_size
attribute that can be set on GPU kernels to override the default value.

Reviewed By: whchung

Differential Revision: https://reviews.llvm.org/D115741




More information about the All-commits mailing list