[all-commits] [llvm/llvm-project] 6fef0f: Revert unnecessary and incorrect change made to Gr...
jamieschmeiser via All-commits
all-commits at lists.llvm.org
Tue Dec 14 05:43:12 PST 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 6fef0ffa14a38c2146c395cc4f39d80844ecc639
https://github.com/llvm/llvm-project/commit/6fef0ffa14a38c2146c395cc4f39d80844ecc639
Author: Jamie Schmeiser <schmeise at ca.ibm.com>
Date: 2021-12-14 (Tue, 14 Dec 2021)
Changed paths:
M llvm/include/llvm/Support/GraphWriter.h
Log Message:
-----------
Revert unnecessary and incorrect change made to GraphWriter
Summary:
As pointed out in https://github.com/llvm/llvm-project/issues/52610, the
changes to GraphWriter made in https://reviews.llvm.org/D87202 introduced
some bad code and the changes are actually unnecessary for
-print-changed=dot-cfg. The code in question is guarded by a call to
DefaultDOTGraphTraits::hasEdgeDestLabels() which is always false when the
graph writer is called for -print-changed=dot-cfg. Revert this section of
the changes.
Author: Jamie Schmeiser <schmeise at ca.ibm.com>
Reviewed By:jrtc27(Jessica Clarke), xgupta(Shivam Gupta)
Differential Revision: https://reviews.llvm.org/D115649
More information about the All-commits
mailing list