[all-commits] [llvm/llvm-project] d7ec4d: [MLIR] PresburgerSet subtraction: fix bug where th...

[Arjun P via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d7ec4d0be34f4d99cedff1a06e12f0a664d039d9
      https://github.com/llvm/llvm-project/commit/d7ec4d0be34f4d99cedff1a06e12f0a664d039d9
  Author: Arjun P <arjunpitchanathan at gmail.com>
  Date:   2021-12-12 (Sun, 12 Dec 2021)

  Changed paths:
    M mlir/lib/Analysis/PresburgerSet.cpp
    M mlir/unittests/Analysis/PresburgerSetTest.cpp

  Log Message:
  -----------
  [MLIR] PresburgerSet subtraction: fix bug where the set `b` was not restored properly on return

When subtracting `b \ c`, when there are divisions in `c`, these division
constraints get added to `b`. `b` must be restored to its original state
when returning, but these added divisions constraints were not removed in
one of the return paths. This patch fixes this and deduplicates the
restoration logic by encapuslating it in a lambda `restoreState`. The patch
also includes a regression test for the bug fix.

Reviewed By: Groverkss

Differential Revision: https://reviews.llvm.org/D115577