[all-commits] [llvm/llvm-project] b28926: [mlir][spirv] Add serialization control to emit sy...

[Lei Zhang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b289266cb2398cebca0ba1ecfc6242470cc7cedd
      https://github.com/llvm/llvm-project/commit/b289266cb2398cebca0ba1ecfc6242470cc7cedd
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M mlir/include/mlir/Target/SPIRV/SPIRVBinaryUtils.h
    M mlir/include/mlir/Target/SPIRV/Serialization.h
    M mlir/lib/Target/SPIRV/Deserialization/DeserializeOps.cpp
    M mlir/lib/Target/SPIRV/Deserialization/Deserializer.h
    M mlir/lib/Target/SPIRV/Serialization/Serialization.cpp
    M mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
    M mlir/lib/Target/SPIRV/Serialization/Serializer.h
    M mlir/lib/Target/SPIRV/TranslateRegistration.cpp
    M mlir/unittests/Dialect/SPIRV/SerializationTest.cpp

  Log Message:
  -----------
  [mlir][spirv] Add serialization control to emit symbol name

In SPIR-V, symbol names are encoded as `OpName` instructions.
They are not semantic impacting and can be omitted, which can
reduce the binary size.

Reviewed By: scotttodd

Differential Revision: https://reviews.llvm.org/D115531


  Commit: 222d7fc7f81936edf488bc85acf3ea5d5300bca3
      https://github.com/llvm/llvm-project/commit/222d7fc7f81936edf488bc85acf3ea5d5300bca3
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
    M mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
    M mlir/unittests/Dialect/SPIRV/SerializationTest.cpp

  Log Message:
  -----------
  [mlir][spirv] Avoid duplicated Block decoration during serialization

It's legal per the Vulkan / SPIR-V spec; still it's better to avoid
such duplication to have cleaner blob and reduce the binary size.

Reviewed By: scotttodd

Differential Revision: https://reviews.llvm.org/D115532


  Commit: 1bfa40a5d6e117bd932a928961a67c17380be83e
      https://github.com/llvm/llvm-project/commit/1bfa40a5d6e117bd932a928961a67c17380be83e
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/TargetAndABI.td

  Log Message:
  -----------
  [mlir][spirv] Change default subgroup size

This should really come from a matching target environment. But
as a default, it can be handy (to avoid always listing the full
resource limits attribute in IR, etc.). It's common to see 32
so use that as the subgroup size.

Reviewed By: scotttodd

Differential Revision: https://reviews.llvm.org/D115534


  Commit: 3ed47bcc9618639012a43a0edf8a2f7ceeda36d1
      https://github.com/llvm/llvm-project/commit/3ed47bcc9618639012a43a0edf8a2f7ceeda36d1
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2021-12-10 (Fri, 10 Dec 2021)

  Changed paths:
    M mlir/include/mlir/Target/SPIRV/SPIRVBinaryUtils.h
    M mlir/lib/Target/SPIRV/Deserialization/DeserializeOps.cpp
    M mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp
    M mlir/lib/Target/SPIRV/Deserialization/Deserializer.h
    M mlir/lib/Target/SPIRV/SPIRVBinaryUtils.cpp
    M mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
    M mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
    M mlir/lib/Target/SPIRV/Serialization/Serializer.h

  Log Message:
  -----------
  [mlir][spirv] Propagate LogicalResult in (de)serialization

`(void)` was added when LogicalResult was marked as non
discard. This commit cleans them up to properly propagate
failures.

Reviewed By: scotttodd

Differential Revision: https://reviews.llvm.org/D115541


Compare: https://github.com/llvm/llvm-project/compare/db124df49506...3ed47bcc9618