[all-commits] [llvm/llvm-project] d6f9bb: [MLIR] FlatAffineConstraints::isIntegerEmpty: fix ...

[Arjun P via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d6f9bb0321e78ae1c920d10da0a369a11dfac6aa
      https://github.com/llvm/llvm-project/commit/d6f9bb0321e78ae1c920d10da0a369a11dfac6aa
  Author: Arjun P <arjunpitchanathan at gmail.com>
  Date:   2021-12-11 (Sat, 11 Dec 2021)

  Changed paths:
    M mlir/lib/Analysis/Presburger/Simplex.cpp
    M mlir/unittests/Analysis/AffineStructuresTest.cpp

  Log Message:
  -----------
  [MLIR] FlatAffineConstraints::isIntegerEmpty: fix bug in computation of duals

The method that was previously used for computing dual variables was incorrect.
This was used in the integer emptiness check algorithm, where this bug could lead to much longer running times. (Due to the way it is used, this never results in an incorrect emptiness check result.)

This patch fixes the dual computation and adds some additional asserts that catch this bug, along with regression test cases that trigger the asserts when the incorrect dual computation is used.

Reviewed By: Groverkss

Differential Revision: https://reviews.llvm.org/D113803